James Long
85 lines
3.4 KiB
TypeScript
85 lines
3.4 KiB
TypeScript
// Regression: a stored step-finish part with a negative token count made the
|
|
// messages endpoint 400. Some providers reported `outputTokens` excluding
|
|
// reasoning while also reporting `reasoningTokens` separately, so the
|
|
// `outputTokens - reasoningTokens` math in Session.getUsage underflowed to
|
|
// negative. The pre-fix `safe()` clamp only guarded against non-finite. The
|
|
// strict `NonNegativeInt` schema then made every load of the message list
|
|
// fail to encode, killing Desktop boot for every user with such a row.
|
|
import { describe, expect } from "bun:test"
|
|
import { LayerNode } from "@opencode-ai/core/effect/layer-node"
|
|
import { Effect, Layer } from "effect"
|
|
import { eq } from "drizzle-orm"
|
|
|
|
import { SessionPaths } from "../../src/server/routes/instance/httpapi/groups/session"
|
|
import { Session } from "@/session/session"
|
|
import { MessageID, PartID } from "../../src/session/schema"
|
|
import { Database } from "@opencode-ai/core/database/database"
|
|
import { PartTable } from "@opencode-ai/core/session/sql"
|
|
import { resetDatabase } from "../fixture/db"
|
|
import { TestInstance } from "../fixture/fixture"
|
|
import { testEffect } from "../lib/effect"
|
|
import { ProviderV2 } from "@opencode-ai/core/provider"
|
|
import { ModelV2 } from "@opencode-ai/core/model"
|
|
import { httpApiLayer, requestInDirectory } from "./httpapi-layer"
|
|
|
|
const it = testEffect(Layer.mergeAll(LayerNode.compile(LayerNode.group([Session.node, Database.node])), httpApiLayer))
|
|
|
|
function seedNegativeTokenSession() {
|
|
return Effect.gen(function* () {
|
|
const session = yield* Session.Service
|
|
const info = yield* session.create({})
|
|
const message = yield* session.updateMessage({
|
|
id: MessageID.ascending(),
|
|
role: "user",
|
|
sessionID: info.id,
|
|
agent: "build",
|
|
model: { providerID: ProviderV2.ID.make("test"), modelID: ModelV2.ID.make("test") },
|
|
time: { created: Date.now() },
|
|
})
|
|
const partID = PartID.ascending()
|
|
yield* session.updatePart({
|
|
id: partID,
|
|
sessionID: info.id,
|
|
messageID: message.id,
|
|
type: "step-finish",
|
|
reason: "stop",
|
|
cost: 0,
|
|
tokens: { input: 0, output: 0, reasoning: 0, cache: { read: 0, write: 0 } },
|
|
})
|
|
|
|
// Bypass the schema with a direct SQL update to install the
|
|
// negative `output` value we want to test loading.
|
|
const { db } = yield* Database.Service
|
|
yield* db
|
|
.update(PartTable)
|
|
.set({
|
|
data: {
|
|
type: "step-finish",
|
|
reason: "stop",
|
|
cost: 0,
|
|
tokens: { input: 0, output: -42, reasoning: 0, cache: { read: 0, write: 0 } },
|
|
} as never,
|
|
})
|
|
.where(eq(PartTable.id, partID))
|
|
.run()
|
|
.pipe(Effect.orDie)
|
|
|
|
return info.id
|
|
})
|
|
}
|
|
|
|
describe("messages endpoint tolerates legacy negative token counts", () => {
|
|
it.instance(
|
|
"returns 200 even when a step-finish part has tokens.output < 0",
|
|
Effect.gen(function* () {
|
|
yield* Effect.addFinalizer(() => Effect.promise(() => resetDatabase()))
|
|
const test = yield* TestInstance
|
|
const sessionID = yield* seedNegativeTokenSession()
|
|
const url = `${SessionPaths.messages.replace(":sessionID", sessionID)}?limit=80&directory=${encodeURIComponent(test.directory)}`
|
|
const res = yield* requestInDirectory(url, test.directory)
|
|
expect(res.status, "messages endpoint 400'd on legacy negative tokens").not.toBe(400)
|
|
}),
|
|
{ git: true, config: { formatter: false, lsp: false } },
|
|
)
|
|
})
|