Files
Kilo-Org_kilocode/packages/opencode/test/tool/recall.test.ts
T
Imanol Maiztegui e4c9b4363e refactor(session): replace promise facade helpers with Effect service calls (#10731)
Migrate all Session.* promise-based helper usage (create, get, messages,
updateMessage, updatePart, setPermission, children, fork) to direct
Effect service consumption via Session.Service. This eliminates the
makeRuntime-backed legacy promise wrappers from session.ts and updates
all dependent modules and tests to use the Effect-based interface.

Key changes:
- Remove exported promise helpers (create, get, messages, etc.) from
  session/session.ts along with the module-level makeRuntime instance
- Update kilo-sessions, remote-sender, allow-everything permission,
  plan-followup, recall tool, and fork module to yield Session.Service
- Convert remapChildren from async function to Effect generator
- Add PlanFollowupRuntime.session helper for effectful session access
- Update all affected test files to use Effect.runPromise with
  Session.Service.use pattern
- Remove session/session.ts from the promise facade allowlist and
  update test allowlist counts accordingly
2026-05-29 16:19:15 +02:00

143 lines
4.9 KiB
TypeScript

// kilocode_change - new file
import { afterEach, beforeEach, describe, expect, mock, spyOn, test } from "bun:test"
import { $ } from "bun"
import { Effect } from "effect"
import { Session } from "../../src/session/session"
import path from "path"
import { WithInstance } from "../../src/project/with-instance"
import { RecallTool } from "../../src/tool/recall"
import { AppRuntime } from "../../src/effect/app-runtime"
import { resetDatabase } from "../fixture/db"
import { tmpdir } from "../fixture/fixture"
import type { Tool } from "../../src/tool/tool"
import { SessionID, MessageID } from "../../src/session/schema"
import { RemoteSender } from "../../src/kilo-sessions/remote-sender"
beforeEach(() => {
spyOn(RemoteSender, "create").mockReturnValue({ handle() {}, dispose() {} })
})
const ctx: Tool.Context = {
sessionID: SessionID.make("ses_test"),
messageID: MessageID.make("msg_test"),
callID: "call_test",
agent: "code",
abort: AbortSignal.any([]),
messages: [],
metadata: () => Effect.void,
ask: () => Effect.void,
}
afterEach(async () => {
mock.restore()
await resetDatabase()
})
const create = (title: string) =>
Effect.runPromise(Session.Service.use((svc) => svc.create({ title })).pipe(Effect.provide(Session.defaultLayer)))
describe("tool.recall", () => {
test("search is limited to the current project worktrees", async () => {
await using first = await tmpdir({ git: true })
await using second = await tmpdir({ git: true })
const worktree = path.join(first.path, "..", path.basename(first.path) + "-worktree")
try {
await $`git worktree add ${worktree} -b test-branch-${Date.now()}`.cwd(first.path).quiet()
await Bun.write(path.join(first.path, ".git", "opencode"), "stale-project-id")
try {
await WithInstance.provide({
directory: first.path,
fn: () => create("search-target root"),
})
await WithInstance.provide({
directory: worktree,
fn: () => create("search-target worktree"),
})
await WithInstance.provide({
directory: second.path,
fn: () => create("search-target other"),
})
const result = await WithInstance.provide({
directory: first.path,
fn: async () => {
const info = await AppRuntime.runPromise(RecallTool)
const tool = await AppRuntime.runPromise(info.init())
return AppRuntime.runPromise(tool.execute({ mode: "search", query: "search-target" }, ctx))
},
})
expect(result.output).toContain("search-target root")
expect(result.output).toContain("search-target worktree")
expect(result.output).not.toContain("search-target other")
} finally {
mock.restore()
}
} finally {
await $`git worktree remove ${worktree}`.cwd(first.path).quiet().nothrow()
}
})
test("read rejects sessions from another project", async () => {
await using first = await tmpdir({ git: true })
await using second = await tmpdir({ git: true })
try {
const session = await WithInstance.provide({
directory: second.path,
fn: () => create("other-project-session"),
})
const err = await WithInstance.provide({
directory: first.path,
fn: async () => {
const info = await AppRuntime.runPromise(RecallTool)
const tool = await AppRuntime.runPromise(info.init())
return AppRuntime.runPromise(tool.execute({ mode: "read", sessionID: session.id }, ctx)).catch(
(error: unknown) => error as Error,
)
},
})
expect(err).toBeInstanceOf(Error)
expect((err as Error).message).toContain("belongs to a different workspace")
} finally {
mock.restore()
}
})
test("read allows sessions from sibling worktrees when project IDs drift", async () => {
await using first = await tmpdir({ git: true })
const worktree = path.join(first.path, "..", path.basename(first.path) + "-worktree")
try {
await $`git worktree add ${worktree} -b test-branch-${Date.now()}`.cwd(first.path).quiet()
await Bun.write(path.join(first.path, ".git", "opencode"), "stale-project-id")
try {
const session = await WithInstance.provide({
directory: worktree,
fn: () => create("worktree readable"),
})
const result = await WithInstance.provide({
directory: first.path,
fn: async () => {
const info = await AppRuntime.runPromise(RecallTool)
const tool = await AppRuntime.runPromise(info.init())
return AppRuntime.runPromise(tool.execute({ mode: "read", sessionID: session.id }, ctx))
},
})
expect(result.output).toContain("# Session: worktree readable")
} finally {
mock.restore()
}
} finally {
await $`git worktree remove ${worktree}`.cwd(first.path).quiet().nothrow()
}
})
})